feat: Add sync APIs for "Deno.permissions" #17019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
commented
Dec 12, 2022
|
If we are to add |
|
I'm happy to do so in a couple follow up PRs if you're sure 🤙🏾 |
Great, I think they should all be added in this PR |
iuioiua
changed the title
Deno.permissions.querySync()querySync(), revokeSync() and requestSync()
iuioiua
commented
Dec 13, 2022
|
#17094 is a prerequisite for this PR. |
|
Fixing conflicts |
|
LGTM |
dsherret
reviewed
Jan 24, 2023
cli/tsc/dts/lib.deno.ns.d.ts
Outdated
| * assertEquals(status.state, "granted"); | ||
| * }, | ||
| * }); | ||
| * ``` |
There was a problem hiding this comment.
Duplicating all the examples and adding sync versions for these properties seems to add a bit too much noise. Maybe we should only document the async versions and remove these additions?
bartlomieju
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
LGTM to me too. Thanks @iuioiua, I'll update the commit message and land this.
bartlomieju
changed the title
querySync(), revokeSync() and requestSync()
This was referenced Jan 28, 2023
rivy
added a commit
to rivy-js/yargs
that referenced
this pull request
Oct 30, 2023
…0.0+) - `Deno.permissions.querySync()` added in Deno v1.30.0 (on 2023-01-25) - see [suggest: Deno.permissions.querySync](denoland/deno#15576) - see [feat: Add sync APIs for "Deno.permissions"](denoland/deno#17019) - see [v1.30.0](https://github.com/denoland/deno/releases/tag/v1.30.0) released on 2023-01-25
rivy
added a commit
to rivy-js/yargs
that referenced
this pull request
Oct 30, 2023
- `Deno.permissions.querySync()` added in Deno v1.30.0 (on 2023-01-25) - see [suggest: Deno.permissions.querySync](denoland/deno#15576) - see [feat: Add sync APIs for "Deno.permissions"](denoland/deno#17019) - see [v1.30.0](https://github.com/denoland/deno/releases/tag/v1.30.0) released on 2023-01-25
rivy
added a commit
to rivy-js/yargs
that referenced
this pull request
Nov 20, 2023
- `Deno.permissions.querySync()` added in Deno v1.30.0 (on 2023-01-25) - see [suggest: Deno.permissions.querySync](denoland/deno#15576) - see [feat: Add sync APIs for "Deno.permissions"](denoland/deno#17019) - see [v1.30.0](https://github.com/denoland/deno/releases/tag/v1.30.0) released on 2023-01-25
rivy
added a commit
to rivy-js/yargs
that referenced
this pull request
Nov 22, 2023
- `Deno.permissions.querySync()` added in Deno v1.30.0 (on 2023-01-25) - see [suggest: Deno.permissions.querySync](denoland/deno#15576) - see [feat: Add sync APIs for "Deno.permissions"](denoland/deno#17019) - see [v1.30.0](https://github.com/denoland/deno/releases/tag/v1.30.0) released on 2023-01-25
rivy
added a commit
to rivy-js/yargs
that referenced
this pull request
Nov 23, 2023
- `Deno.permissions.querySync()` added in Deno v1.30.0 (on 2023-01-25) - see [suggest: Deno.permissions.querySync](denoland/deno#15576) - see [feat: Add sync APIs for "Deno.permissions"](denoland/deno#17019) - see [v1.30.0](https://github.com/denoland/deno/releases/tag/v1.30.0) released on 2023-01-25
rivy
added a commit
to rivy-js/yargs
that referenced
this pull request
Nov 23, 2023
- `Deno.permissions.querySync()` added in Deno v1.30.0 (on 2023-01-25) - see [suggest: Deno.permissions.querySync](denoland/deno#15576) - see [feat: Add sync APIs for "Deno.permissions"](denoland/deno#17019) - see [v1.30.0](https://github.com/denoland/deno/releases/tag/v1.30.0) released on 2023-01-25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds sync versions of async APIs to "Deno.permissions"
namespace.
Following APIs were added:
Closes #15576.